Skip to content

fix(ios): Fix check for dynamic lib#6032

Open
PeterStaev wants to merge 1 commit intoNativeScript:mainfrom
PeterStaev:fix-incorrect-dynamic-lib-check
Open

fix(ios): Fix check for dynamic lib#6032
PeterStaev wants to merge 1 commit intoNativeScript:mainfrom
PeterStaev:fix-incorrect-dynamic-lib-check

Conversation

@PeterStaev
Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

There seems to be a problem with the check whether or not a library is dynamic so it can be set to embed. This causes problems with some 3rd party plugins (see triniwiz/nativescript-plugins#223) and makes the apps crash on startup (both simulator and device).

For some reason the current logic isn't looking at the BinaryPath that there is in the Info.plist for the framework, but is trying to "guess" the path to the binary from other parts.

For example for the CouchBase plugin the path that the current logic generates is:

/path/to/project/node_modules/@triniwiz/nativescript-couchbase/platforms/ios/CouchbaseLite.xcframework/ios-arm64_x86_64-maccatalyst/CouchbaseLite.framework/CouchbaseLite

But the correct path is:

/path/to/project/node_modules/@triniwiz/nativescript-couchbase/platforms/ios/CouchbaseLite.xcframework/ios-arm64_x86_64-maccatalyst/CouchbaseLite.framework/Versions/A/CouchbaseLite

What is the new behavior?

The binary path is calculated first based on the BinaryPath from the Info.plist and if that is not present the old logic is used.

Fixes/Implements/Closes #[Issue Number].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant